ENH: Always do true division on Python 2.X #5439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this version actually forces `a / b` to always do truediv as well. It's less complicated to maintain if we do it that way, but it's also possible to have this `a / b` use div and `a.div(b)` use truediv, just might be strange. This is definitely different from numpy behavior. We also may need to add the division future import to more places.
|
you can't just put the `from future import division |
|
It's module level :-/ |
|
Just want to make it clear that this is the end result on Python 2.X without the future import (working interactively): In [1]: import pandas as pd
In [2]: import numpy as np
In [3]: arr = np.array([1, 2, 3, 4])
In [4]: arr2 = np.array([5, 3, 2, 1])
In [5]: arr / arr2
Out[5]: array([0, 0, 1, 4])
In [6]: pd.Series(arr) / pd.Series(arr2)
Out[6]:
0 0.200000
1 0.666667
2 1.500000
3 4.000000
dtype: float64
In [7]:Whereas before this PR: In [2]: pd.Series(arr) / pd.Series(arr2)
Out[2]:
0 0
1 0
2 1
3 4
dtype: int64 |
|
maybe make a separate section in v0.13 to highlite this (with an example like this) |
|
yep, just did that. On Tue, Nov 5, 2013 at 7:16 AM, jreback [email protected] wrote:
|
|
looks ok to me |
jtratner
added a commit
that referenced
this pull request
Nov 5, 2013
ENH: Always do true division on Python 2.X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5356.
Note: this version actually forces
a / bto always do truediv as well. It'sless complicated to maintain if we do it that way, but it's also possible to
have this
a / buse div anda.div(b)use truediv, just might be strange.This is definitely different from numpy behavior.
We also may need to add the division future import to more places.